Also, add to RAML / JSON schema
Details
Details
run case in MARATHON-7421; upgrade Marathon 1.4-1.5 with ipAddress port labels
Diff Detail
Diff Detail
- Repository
- rMARATHON marathon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
✗ Build of 3358 failed jenkins-public-marathon-phabricator-116.
Error message:
Stage Compile and Test failed.
Comment Actions
^ known flake. We should mark unstable. Failed for text only change here: https://phabricator.mesosphere.com/D795
Comment Actions
Nice catch, Tim. You'll also want to update the AppConversion code so that migrations to 1.5 don't drop the labels. Currently the conversion code doesn't support them (because they weren't in the RAML):
implicit val discoveryPortProtoRamlWriter: Writes[org.apache.mesos.Protos.Port, IpDiscoveryPort] = Writes { port => IpDiscoveryPort( number = port.whenOrElse(_.hasNumber, _.getNumber, IpDiscoveryPort.DefaultNumber), name = port.getName, protocol = port.when(_.hasProtocol, _.getProtocol).flatMap(NetworkProtocol.fromString).getOrElse(IpDiscoveryPort.DefaultProtocol) ) }
Comment Actions
✔ Build of 3379 completed jenkins-public-marathon-phabricator-139.
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
"url": "https://downloads.mesosphere.io/marathon/snapshots/marathon-1.5.0-SNAPSHOT-550-g4b5209f.tgz", "sha1"" "3889acadd9570c463369c69423510caed75c3a82"