HomeMesosphereNo notifications. 4 unresolved issues.

POD host port normalization
ClosedAll Users

Authored by unterstein on May 24 2017, 11:17 AM.

Details

Summary

pod normalization w/ refactorings:

  • introduce NormalizationException; change SerializationFailedExceptions thrown by normalization to use it
  • centralize network name normalization in NetworkNormalization
  • refactor pod normalization from PodResources to PodNormalization
  • fix redundant normalization invocation in PodResources
  • allow empty hostPort for endpoints when host or bridge networking is used and normalize it to 0
  • revert changes to PortsMatcher
  • added unit tests

Depends: D801

Test Plan

sbt test

Diff Detail

Repository
rMARATHON marathon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Changes from before your most recent comment are hidden. Show Older Changes
jeschkies accepted this revision.Jun 12 2017, 11:10 AM

Thanks!

unterstein updated this revision to Diff 3478.Jun 12 2017, 12:26 PM
  • adapted feedback
jenkins requested changes to this revision.Jun 12 2017, 12:42 PM
This revision now requires changes to proceed.Jun 12 2017, 12:42 PM
✗ Build of 3478 failed jenkins-public-marathon-phabricator-211.

Error message:

Stage Compile and Test failed.

(๑′°︿°๑)

jenkins accepted this revision.Jun 12 2017, 1:09 PM
This revision is now accepted and ready to land.Jun 12 2017, 1:09 PM
✔ Build of 3478 completed jenkins-public-marathon-phabricator-213.

You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:

"url": "https://downloads.mesosphere.io/marathon/snapshots/marathon-1.5.0-SNAPSHOT-572-g58bfb57.tgz",
"sha1"" "3bacd07512b4b124570c7a2c944a939a309e3afa"

\\ ٩( ᐛ )و //

This revision was automatically updated to reflect the committed changes.