HomeMesosphereNo notifications. 4 unresolved issues.

Add new Jenkinsfile for phabricator (and share the code with the regular pipeline)
ClosedAll Users

Authored by jasongilanfarr on Apr 5 2017, 12:45 AM.

Details

Reviewers
aquamatthias
timcharper
jenkins
jeschkies
Commits
rMARATHON5c44d14708a3: Run Unstable test marker as root
rMARATHONe3ac47bc595b: Correct script location
rMARATHONfd4dd8efdda9: Really don't run unstable if there are none
rMARATHON02f8e7274696: Add documentation to ammonite script
rMARATHON586cc29d788a: Correct node name
rMARATHON0d4311a5986a: Fix reporting test results to phabricator
rMARATHON84653f1fb5b1: Permissions on .arcrc are too open on the new node.
rMARATHONe14c25aaaee5: Workaround more issues in the newer AMI
rMARATHON39a636f83300: Fix formatting
rMARATHON2bc79b703d3a: Remove extra "
rMARATHONb8133d08e062: Include the gitCommit in package_binaries
rMARATHON8e6a798e0e27: Address review comments and move more to ammonite
rMARATHONd8a0efbb729f: Don't kill the kill script
rMARATHON8dce14e3b32e: I should learn to spell
rMARATHON29b3e27b368a: PREVIEW: Add new Jenkinsfile for phabricator (and share the code with the…
rMARATHON0bbd1cab78b6: Prune tags on fetch
rMARATHON3e04e1f83cd8: A little more cleanup
rMARATHON3cc4b38e46ba: Add new Jenkinsfile for phabricator (and share the code with the regular…
rMARATHONa63d9eba01a3: Missed a 'testcase'
rMARATHON1fc7be07f526: Use _ instead of -
rMARATHON930f44e56bc1: Now with ammonite for marking the unstable junit results
JIRA Issues
JIRA MARATHON-7194 Make Unstable Tests annoying
JIRA MARATHON-7093 Fail build if after test, the git history is not clean.
JIRA MARATHON-7059 Jenkins <-> Phabricator Integration
JIRA MARATHON-2988 Build should check for formatting changes
JIRA MARATHON-7135 master builds and phab(diff)-triggered builds should use consistent test coverage rules
Summary
  • Add marathon.groovy that is shared between the jobs.
  • Use marathon.groovy in the Jenkinsfile
  • Add unstable test reporting to the master/release pipeline.
  • Create new jenkinsfile for phabricator builds
    • Includes unstable tests (adds a warning comment).
    • the current plugin isn't compatible with pipeline.
    • Still working out the "reject" vs "add comment"
Test Plan

Diff Detail

Repository
rMARATHON marathon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Changes from before your most recent comment are hidden. Show Older Changes
jeschkies accepted this revision.Apr 7 2017, 11:08 PM

I'm sorry. I did not think about the policy of no "requests for changes". You've got my go :).

This revision is now accepted and ready to land.Apr 7 2017, 11:08 PM
  • Missed a 'testcase'
  • Fix reporting test results to phabricator
This revision now requires changes to proceed.Apr 8 2017, 12:12 AM
  • I should learn to spell
This revision now requires changes to proceed.Apr 8 2017, 12:54 AM
  • Remove extra "
This revision is now accepted and ready to land.Apr 8 2017, 2:20 AM
  • version with git describe
  • Version with Git Describe everywhere
This revision now requires changes to proceed.Apr 10 2017, 9:59 AM
  • Prune tags on fetch
This revision now requires changes to proceed.Apr 10 2017, 10:36 AM
  • Delete phabricator tags
This revision now requires changes to proceed.Apr 10 2017, 6:36 PM
This revision is now accepted and ready to land.Apr 10 2017, 7:03 PM
  • Install dependencies in main Jenkinsfile too
  • Improve detection of unstable test
  • Really don't run unstable if there are none
  • Make unstable even better for phab reviews
This revision was automatically updated to reflect the committed changes.