HomeMesosphereNo notifications. 4 unresolved issues.
  • Search
Differential D300

Turn off debug for jetty
ClosedAll Users
Actions

Authored by timcharper on Dec 8 2016, 10:02 PM.

Details

Reviewers
jdef
• jasongilanfarr
Commits
rMARATHON28ad931ddcd0: Turn off debug for jetty
rMARATHON6984205bf542: Turn off debug for jetty
rMARATHONa5be22ef7048: Turn off debug for jetty
Summary

The debug logs for jetty are almost never helpful; this reduces noise
significantly when turning on marathon debug logging.

Test Plan

n/a

Diff Detail

Repository
rMARATHON marathon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
timcharper retitled this revision from to Turn off debug for jetty.Dec 8 2016, 10:02 PM
timcharper updated this object.
timcharper edited the test plan for this revision. (Show Details)
timcharper added reviewers: • jasongilanfarr, jdef.
jdef accepted this revision.Dec 8 2016, 11:55 PM
This revision is now accepted and ready to land.Dec 8 2016, 11:55 PM
• jasongilanfarr requested changes to this revision.Dec 9 2016, 12:33 AM

This should have no effect at all. The root logger is at info, so how is this any different?

This revision now requires changes to proceed.Dec 9 2016, 12:33 AM
• jasongilanfarr accepted this revision.Dec 9 2016, 12:42 AM

when the logging_level flag is set to DEBUG that changes the default logging to DEBUG but the other levels that have overrides stay that way .. yes?

Well that's confusing.

This revision is now accepted and ready to land.Dec 9 2016, 12:42 AM
jdef added a comment.Dec 9 2016, 12:43 AM

when the logging_level flag is set to DEBUG that changes the default
logging to DEBUG but the other levels that have overrides stay that way ..
yes?

timcharper added a comment.Dec 9 2016, 12:57 AM

This indeed does change things. logging_level modifies the root logging level. The override prevents worthless / noisy messages from cluttering the log.

Closed by commit rMARATHON6984205bf542: Turn off debug for jetty (authored by timcharper). · Explain WhyDec 9 2016, 12:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Msrc/main/resources/logback.xml (1 line)

Diff 1174

View Options

src/main/resources/logback.xml

11<?xml version="1.0" encoding="UTF-8"?>
22
33<configuration>
44 <shutdownHook class="ch.qos.logback.core.hook.DelayingShutdownHook"/>
55 <appender name="stdout" class="ch.qos.logback.core.ConsoleAppender">
66 <encoder>
77 <pattern>[%date] %-5level %message \(%logger:%thread\)%n</pattern>
88 </encoder>
99 </appender>
1010 <appender name="async" class="ch.qos.logback.classic.AsyncAppender">
1111 <appender-ref ref="stdout" />
1212 <queueSize>1024</queueSize>
1313 </appender>
1414
1515 <!-- Don't log ZooKeeper AuthInfo from com.twitter.zk.NativeConnector -->
1616 <logger name="native-zk-connector" level="WARN" />
17 <logger name="org.eclipse" level="INFO"/>
1718
1819 <root level="INFO">
1920 <appender-ref ref="async"/>
2021 </root>
2122</configuration>