HomeMesosphereNo notifications. 4 unresolved issues.

Log rejected task ops on debug.
ClosedAll Users

Authored by aquamatthias on Dec 6 2016, 2:38 PM.

Details

Summary

When Launching lots of tasks Journald is pegged.
In particular, it's this line:
INFO Task op 'LaunchTask' for instance [xxx] was REJECTED, reason 'xxx', rescheduling.

This needs to be cherry picked in Marathon 1.4

Test Plan

sbt test

Diff Detail

Repository
rMARATHON marathon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Changes from before your most recent comment are hidden. Show Older Changes
jeschkies requested changes to this revision.Dec 6 2016, 2:54 PM
jeschkies added a subscriber: zen-dog.

I think the debug flag is not needed.

src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala
237–239

I thought isDebugEnabled is not necessary when using { }.

Overall I'd like to have some overview when to use StrictLogging and when to use AkkaLogging. As @zen-dog showed we should not use AkkaLogging from within a future. This makes it sometimes hard when the future is used in an actor.

This revision now requires changes to proceed.Dec 6 2016, 2:54 PM
aquamatthias updated this revision to Diff 1105.Dec 6 2016, 3:21 PM
  • Remove if clause.
aquamatthias marked an inline comment as done.Dec 6 2016, 3:24 PM
aquamatthias added inline comments.
src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala
237–239

Removed. Probably a bigger topic of discussion. My take is: use the scala logger everywhere.
They are safe to use always and automatically translate to if (log.isXxxEnabled) log.xxx()

jeschkies accepted this revision.Dec 6 2016, 3:50 PM
jeschkies added inline comments.
src/main/scala/mesosphere/marathon/core/launchqueue/impl/TaskLauncherActor.scala
237–239

+1

This revision is now accepted and ready to land.Dec 6 2016, 3:50 PM
unterstein accepted this revision.Dec 7 2016, 6:50 PM
This revision was automatically updated to reflect the committed changes.
aquamatthias marked an inline comment as done.