HomeMesosphereNo notifications. 4 unresolved issues.

Changed default of UnreachableEnabled to (0,0)
ClosedAll Users

Authored by unterstein on Sep 21 2017, 12:37 PM.

Diff Detail

Repository
rMARATHON marathon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
unterstein created this revision.Sep 21 2017, 12:37 PM
jenkins requested changes to this revision.Sep 21 2017, 12:42 PM
This revision now requires changes to proceed.Sep 21 2017, 12:42 PM
jenkins accepted this revision.Sep 21 2017, 12:57 PM
This revision is now accepted and ready to land.Sep 21 2017, 12:57 PM
✔ Build of 4297 completed jenkins-public-marathon-phabricator-1034.

You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:

\\ ٩( ᐛ )و //

meichstedt added inline comments.
docs/docs/rest-api/public/api/v2/schema/AppDefinition.json
826–827

Must be less than expungeAfterSeconds

Is this still correct? Less or zero?

831–832
  1. s/unreachableExpungeAfter/expungeAfterSeconds
  1. s/This value is required to be greater than inactiveAfterSeconds/This value is required to be greater than inactiveAfterSeconds unless both are zero.
  1. s/Default is 7 days (604800 seconds)/Default is 0 seconds.

(I didn't escape special characters for obvious reasons ;) )

docs/docs/rest-api/public/api/v2/types/unreachableStrategy.raml
19

Must be less than expungeAfterSeconds or zero.

29

s/unreachableExpungeAfter/expungeAfterSeconds

31

This value is required to be greater than inactiveAfterSeconds unless both are zero.

Thanks! Left a few comments.

unterstein marked 5 inline comments as done.Sep 21 2017, 5:16 PM

Thanks for the feedback on the docs @meichstedt

docs/docs/rest-api/public/api/v2/schema/AppDefinition.json
826–827

I would go for less than or equals. Minimum already described in first class description.

docs/docs/rest-api/public/api/v2/types/unreachableStrategy.raml
19

I would go for less than or equals. Minimum already described in first class description.

unterstein updated this revision to Diff 4299.Sep 21 2017, 5:16 PM
unterstein marked 2 inline comments as done.
  • adressed docs feedback
jenkins requested changes to this revision.Sep 21 2017, 5:18 PM
This revision now requires changes to proceed.Sep 21 2017, 5:18 PM
jenkins accepted this revision.Sep 21 2017, 5:32 PM
This revision is now accepted and ready to land.Sep 21 2017, 5:32 PM
✔ Build of 4299 completed jenkins-public-marathon-phabricator-1036.

You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:

\\ ٩( ᐛ )و //

marked comments as done

Closed by commit rMARATHON0480f17661fb: Changed default of UnreachableEnabled to (0,0) (#5523) (authored by unterstein, committed by GitHub <noreply@github.com>). · Explain WhySep 25 2017, 1:53 PM
This revision was automatically updated to reflect the committed changes.