Most users would expect the same behavior in terms of unreachable task as marathon had before introducing the unreachableStrategy.
Therefore this patch re-introduces the old behavior as default configuration.
Details
- Reviewers
meln1k timcharper kensipe jenkins - Commits
- rMARATHON4530c593f423: Changed default of UnreachableEnabled to (0,0) (#5523) (#5649)
rMARATHON769aed4015a0: Changed default of UnreachableEnabled to (0,0)
rMARATHON0480f17661fb: Changed default of UnreachableEnabled to (0,0) (#5523)
rMARATHON0079fc4767a8: Changed default of UnreachableEnabled to (0,0) (#5523)
rMARATHONe475c53c39fc: Changed default of UnreachableEnabled to (0,0) (#5523) - JIRA Issues
- JIRA MARATHON-7576 Correct the default for UnreachableStrategy
sbt test
sbt integration:test
Diff Detail
- Repository
- rMARATHON marathon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
\\ ٩( ᐛ )و //
docs/docs/rest-api/public/api/v2/schema/AppDefinition.json | ||
---|---|---|
826–827 |
Is this still correct? Less or zero? | |
831–832 |
(I didn't escape special characters for obvious reasons ;) ) | |
docs/docs/rest-api/public/api/v2/types/unreachableStrategy.raml | ||
19 | Must be less than expungeAfterSeconds or zero. | |
29 | s/unreachableExpungeAfter/expungeAfterSeconds | |
31 | This value is required to be greater than inactiveAfterSeconds unless both are zero. |
Thanks for the feedback on the docs @meichstedt
docs/docs/rest-api/public/api/v2/schema/AppDefinition.json | ||
---|---|---|
826–827 | I would go for less than or equals. Minimum already described in first class description. | |
docs/docs/rest-api/public/api/v2/types/unreachableStrategy.raml | ||
19 | I would go for less than or equals. Minimum already described in first class description. |
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
Is this still correct? Less or zero?