HomeMesosphereNo notifications. 4 unresolved issues.
  • Search
Differential D1049

removing references to marathon cmdline options which have been removed
AbandonedAll Users
Actions

Authored by kensipe on Sep 8 2017, 12:08 AM.

Details

Reviewers
zen-dog
jeschkies
meln1k
ichernetsky
timcharper
unterstein
jdef
jenkins
JIRA Issues
JIRA MARATHON-7749 Marathon 1.5 Universe Release
Summary

removed the following:

  • event_subscriber -> docs/docs/rest-api/public/api/v2/examples/info.json:34:
  • http_event_callback_slow_consumer_timeout -> tests/scale/mom.json:3:
  • save_tasks_to_launch_timeout -> tests/scale/mom.json:3:
  • max_tasks_per_offer -> tests/scale/mom.json:3:

tests/system/fixtures/mom-ee-disabled-1.3.json:3:
tests/system/fixtures/mom-ee-disabled-1.4.json:3:
tests/system/fixtures/mom-ee-permissive-1.3.json:3:
tests/system/fixtures/mom-ee-permissive-1.4.json:3:
tests/system/fixtures/mom-ee-strict-1.3.json:3:
tests/system/fixtures/mom-ee-strict-1.4.json:3:

Test Plan

none

Diff Detail

Repository
rMARATHON marathon
Branch
ken/cmdline-flag-removal
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3454
Build 6604: Marathon (revised)Jenkins
Build 6603: arc lint + arc unit
kensipe created this revision.Sep 8 2017, 12:08 AM
kensipe added reviewers: jeschkies, meln1k, ichernetsky, timcharper, unterstein, jdef.Sep 8 2017, 12:09 AM
kensipe edited the summary of this revision. (Show Details)
jenkins requested changes to this revision.Sep 8 2017, 12:11 AM
This revision now requires changes to proceed.Sep 8 2017, 12:11 AM
kensipe updated this revision to Diff 4227.Sep 8 2017, 12:12 AM
  • updating to default
jenkins requested changes to this revision.Sep 8 2017, 12:18 AM
This revision now requires changes to proceed.Sep 8 2017, 12:18 AM
ichernetsky accepted this revision.Sep 8 2017, 12:20 AM
jenkins added a comment.Sep 8 2017, 12:25 AM
✗ Build of 4226 failed jenkins-public-marathon-phabricator-974.

Error message:

Stage Package Docker Image, Debian and RedHat Packages failed.

(๑′°︿°๑)

jenkins added a comment.Sep 8 2017, 12:33 AM
✗ Build of 4227 failed jenkins-public-marathon-phabricator-975.

Error message:

Stage Package Docker Image, Debian and RedHat Packages failed.

(๑′°︿°๑)

zen-dog accepted this revision.Sep 8 2017, 9:18 AM
jdef added a comment.Sep 8 2017, 5:44 PM

I'm confused why 1.3 and 1.4 JSONs are being changed from max_tasks_per_offer to max_instances_per_offer; the old flag was deprecated in 1.4 (but the docs don't indicate that it no longer works).

kensipe abandoned this revision.Sep 21 2017, 6:41 PM

Revision Contents

Diff 4227

View Options

docs/docs/rest-api/public/api/v2/examples/info.json

Show All 25 Lines
2626 },
2727 "zookeeper_config": {
2828 "zk": "zk://localhost:2181/marathon",
2929 "zk_timeout": 10000,
3030 "zk_connection_timeout": 10000,
3131 "zk_session_timeout": 1800000,
3232 "zk_max_versions": 25
3333 },
34 "event_subscriber": null,
3534 "http_config": {
3635 "assets_path": null,
3736 "http_port": 8080,
3837 "https_port": 8443
3938 }
4039}
View Options

tests/scale/mom.json

11{
22 "id": "/marathon-user",
3 "cmd": "LIBPROCESS_PORT=$PORT1 && ./bin/start --checkpoint --decline_offer_duration \"120000\" --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing\" --event_stream_max_outstanding_messages \"50\" --executor \"//cmd\" --failover_timeout \"604800\" --framework_name marathon-user --ha --hostname $LIBPROCESS_IP --http_compression --http_event_callback_slow_consumer_timeout \"10000\" --http_event_request_timeout \"10000\" --http_port $PORT0 --http_realm \"Mesosphere\" --launch_token_refresh_interval \"30000\" --launch_tokens \"100\" --leader_proxy_connection_timeout \"5000\" --leader_proxy_read_timeout \"10000\" --local_port_max \"20000\" --local_port_min \"10000\" --master \"zk://master.mesos:2181/mesos\" --max_tasks_per_offer \"100\" --disable_mesos_authentication --mesos_authentication_principal marathon-user --mesos_leader_ui_url \"/mesos\" --mesos_role marathon-user --metrics --min_revive_offers_interval \"5000\" --offer_matching_timeout \"1000\" --on_elected_prepare_timeout \"180000\" --reconciliation_initial_delay \"15000\" --reconciliation_interval \"600000\" --revive_offers_repetitions \"3\" --save_tasks_to_launch_timeout \"3000\" --scale_apps_initial_delay \"15000\" --scale_apps_interval \"300000\" --store_cache --task_launch_confirm_timeout \"300000\" --task_launch_timeout \"300000\" --task_lost_expunge_gc \"75000\" --task_lost_expunge_initial_delay \"300000\" --task_lost_expunge_interval \"30000\" --task_reservation_timeout \"20000\" --disable_tracing --zk zk://master.mesos:2181/universe/marathon-user --zk_compression --zk_compression_threshold \"65536\" --zk_max_node_size \"1024000\" --zk_max_versions \"25\" --zk_connection_timeout \"10000\" --zk_session_timeout \"10000\" --zk_timeout \"10000\"",
3 "cmd": "LIBPROCESS_PORT=$PORT1 && ./bin/start --checkpoint --decline_offer_duration \"120000\" --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing\" --event_stream_max_outstanding_messages \"50\" --executor \"//cmd\" --failover_timeout \"604800\" --framework_name marathon-user --ha --hostname $LIBPROCESS_IP --http_compression --http_port $PORT0 --http_realm \"Mesosphere\" --launch_token_refresh_interval \"30000\" --launch_tokens \"100\" --leader_proxy_connection_timeout \"5000\" --leader_proxy_read_timeout \"10000\" --local_port_max \"20000\" --local_port_min \"10000\" --master \"zk://master.mesos:2181/mesos\" --max_instances_per_offer \"100\" --disable_mesos_authentication --mesos_authentication_principal marathon-user --mesos_leader_ui_url \"/mesos\" --mesos_role marathon-user --metrics --min_revive_offers_interval \"5000\" --offer_matching_timeout \"10000\" --on_elected_prepare_timeout \"180000\" --reconciliation_initial_delay \"15000\" --reconciliation_interval \"600000\" --revive_offers_repetitions \"3\" --scale_apps_initial_delay \"15000\" --scale_apps_interval \"300000\" --store_cache --task_launch_confirm_timeout \"300000\" --task_launch_timeout \"300000\" --task_lost_expunge_gc \"75000\" --task_lost_expunge_initial_delay \"300000\" --task_lost_expunge_interval \"30000\" --task_reservation_timeout \"20000\" --disable_tracing --zk zk://master.mesos:2181/universe/marathon-user --zk_compression --zk_compression_threshold \"65536\" --zk_max_node_size \"1024000\" --zk_max_versions \"25\" --zk_connection_timeout \"10000\" --zk_session_timeout \"10000\" --zk_timeout \"10000\"",
44 "env": {
55 "JVM_OPTS": "-Xms512m -Xmx1536m"
66 },
77 "instances": 1,
88 "cpus": 2,
99 "mem": 6144,
1010 "constraints": [
1111 [
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines
View Options

tests/system/fixtures/mom-ee-disabled-1.3.json

11{
22 "id": "/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-disabled-1-3 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_tasks_per_offer 1 --mesos_leader_ui_url /mesos --zk zk://master.mesos:2181/universe/marathon-user-ee-1-3",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-disabled-1-3 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_instances_per_offer 1 --mesos_leader_ui_url /mesos --zk zk://master.mesos:2181/universe/marathon-user-ee-1-3",
44 "cpus": 2,
55 "mem": 1536,
66 "disk": 0,
77 "instances": 1,
88 "constraints": [
99 [
1010 "hostname",
1111 "UNIQUE"
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

tests/system/fixtures/mom-ee-disabled-1.4.json

11{
22 "id": "/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-disabled-1-4 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_tasks_per_offer 1 --mesos_leader_ui_url /mesos --zk zk://master.mesos:2181/universe/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-disabled-1-4 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_instances_per_offer 1 --mesos_leader_ui_url /mesos --zk zk://master.mesos:2181/universe/marathon-user-ee",
44 "cpus": 2,
55 "mem": 2048,
66 "disk": 0,
77 "instances": 1,
88 "constraints": [
99 [
1010 "hostname",
1111 "UNIQUE"
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines
View Options

tests/system/fixtures/mom-ee-permissive-1.3.json

11{
22 "id": "/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-permissive-1-3 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_tasks_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee-1-3 --mesos_authentication --mesos_authentication_principal marathon_user_ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-permissive-1-3 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_instances_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee-1-3 --mesos_authentication --mesos_authentication_principal marathon_user_ee",
44 "cpus": 2,
55 "mem": 1536,
66 "disk": 0,
77 "instances": 1,
88 "constraints": [
99 [
1010 "hostname",
1111 "UNIQUE"
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines
View Options

tests/system/fixtures/mom-ee-permissive-1.4.json

11{
22 "id": "/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-permissive-1-4 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_tasks_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee --mesos_authentication --mesos_authentication_principal marathon_user_ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-permissive-1-4 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_instances_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee --mesos_authentication --mesos_authentication_principal marathon_user_ee",
44 "cpus": 2,
55 "mem": 2048,
66 "disk": 0,
77 "instances": 1,
88 "constraints": [
99 [
1010 "hostname",
1111 "UNIQUE"
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines
View Options

tests/system/fixtures/mom-ee-strict-1.3.json

11{
22 "id": "/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-strict-1-3 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_tasks_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee-1-3 --mesos_authentication --mesos_authentication_principal marathon_user_ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-strict-1-3 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_instances_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee-1-3 --mesos_authentication --mesos_authentication_principal marathon_user_ee",
44 "cpus": 2,
55 "mem": 1536,
66 "disk": 0,
77 "instances": 1,
88 "constraints": [
99 [
1010 "hostname",
1111 "UNIQUE"
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines
View Options

tests/system/fixtures/mom-ee-strict-1.4.json

11{
22 "id": "/marathon-user-ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-strict-1-4 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_tasks_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee --mesos_authentication --mesos_authentication_principal marathon_user_ee",
3 "cmd": "cd $MESOS_SANDBOX && LIBPROCESS_PORT=$PORT1 && /marathon/bin/start --default_accepted_resource_roles \"*\" --enable_features \"vips,task_killing,external_volumes,secrets,gpu_resources\" --framework_name marathon-user-ee-strict-1-4 --hostname $LIBPROCESS_IP --http_port $PORT0 --master zk://master.mesos:2181/mesos --max_instances_per_offer 1 --mesos_leader_ui_url /mesos --mesos_role marathon-user-ee --zk zk://master.mesos:2181/universe/marathon-user-ee --mesos_authentication --mesos_authentication_principal marathon_user_ee",
44 "cpus": 2,
55 "mem": 2048,
66 "disk": 0,
77 "instances": 1,
88 "constraints": [
99 [
1010 "hostname",
1111 "UNIQUE"
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines
These changes have failed to build.