TaskStatusEmitter is completely removed from the codebase and replaced by akka eventStream.
Details
- Reviewers
unterstein ichernetsky timcharper kensipe jenkins meichstedt zen-dog - Commits
- rMARATHON50391180e19e: MARATHON-1135 Replace TaskStatusEmitter usage with EventBus
rMARATHONb5e3eca0296b: MARATHON-1135 Replace TaskStatusEmitter usage with EventBus
rMARATHONe6024a6ac4f5: MARATHON-1135 Replace TaskStatusEmitter usage with EventBus - JIRA Issues
- JIRA MARATHON-7794 Replace TaskStatusEmitter usage with EventBus
Task launching still must work
Diff Detail
- Repository
- rMARATHON marathon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
src/test/scala/mesosphere/marathon/core/flow/impl/OfferMatcherLaunchTokensActorTest.scala | ||
---|---|---|
19 | Please remove this empty line. |
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
\\ ٩( ᐛ )و //
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
\\ ٩( ᐛ )و //
Thanks for the fast results! As noted you can simply remove everything related to TaskStatusEmitterPublishStepImpl. InstanceChanges are already published via the PostToEventStreamStepImpl.
src/main/scala/mesosphere/marathon/core/task/update/impl/steps/TaskStatusEmitterPublishStepImpl.scala | ||
---|---|---|
0 | This whole class and related wiring code can be removed. There is the PostToEventStreamStepImpl that handles publishing instance changes to the event stream. Sorry this wasn't clear from the JIRA :| |
src/main/scala/mesosphere/marathon/core/task/update/impl/steps/TaskStatusEmitterPublishStepImpl.scala | ||
---|---|---|
0 | PostToEventStreamStepImpl publishes a little bit different events but I can inline the mentioned line in it. |
Error message:
Stage Package Docker Image, Debian and RedHat Packages failed.
(๑′°︿°๑)
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
\\ ٩( ᐛ )و //
Nearly there ;)
src/main/scala/mesosphere/marathon/core/flow/impl/OfferMatcherLaunchTokensActor.scala | ||
---|---|---|
32 | This should subscribe to InstanceChanged instead (notice the d at the end). The PostToEventStreamStepImpl will publish all events contained in InstanceChange.events. These events are created by InstanceChangedEventsGenerator (the fact that InstanceHealthChanged is handled differently is a tech debt and there's a JIRA for it). | |
45 | Using InstanceChanged, this would be case InstanceChanged(_, _, _, _, instance) if instance.isRunning && instance.state.healthy.fold(true)(_ == true) => offerMatcherManager.addLaunchTokens(1) | |
src/main/scala/mesosphere/marathon/core/task/update/impl/steps/PostToEventStreamStepImpl.scala | ||
24 ↗ | (On Diff #4236) | Please remove this again – not needed, see other comments |
src/main/scala/mesosphere/marathon/core/flow/impl/OfferMatcherLaunchTokensActor.scala | ||
---|---|---|
32 | Got it, thanks! |
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
\\ ٩( ᐛ )و //
Thanks! I left two comments I'd like to have addressed, but they're only about deleting a few more lines.
src/test/scala/mesosphere/marathon/core/flow/impl/OfferMatcherLaunchTokensActorTest.scala | ||
---|---|---|
4 | unused import | |
13–14 | please remove this as well – you should then be able to remove the rx.lang.scala and the InstanceChange imports |
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
This should subscribe to InstanceChanged instead (notice the d at the end). The PostToEventStreamStepImpl will publish all events contained in InstanceChange.events. These events are created by InstanceChangedEventsGenerator (the fact that InstanceHealthChanged is handled differently is a tech debt and there's a JIRA for it).